Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sync with dev #108

Merged
merged 9 commits into from
Sep 24, 2023
Merged

chore: sync with dev #108

merged 9 commits into from
Sep 24, 2023

Conversation

doodlum
Copy link
Owner

@doodlum doodlum commented Sep 24, 2023

No description provided.

alandtse and others added 9 commits September 24, 2023 01:36
* feat: allow adjustment of compiler threads

Compiler threads may be changed in the `Advanced->Compiler Threads`
menu. Defaults to the available cores - 1, but may be adjusted from 1 to
maximum cores. Compiler threads also have been changed to `background`
priority to prevent lock ups on start.

* fix: fix ctd when terminating compiler threads

Switch to BS:thread_pool to abstract thread management and avoid
overhead of killing and starting threads. Instead, only add jobs to
pool when the number of active and queued threads is less than the
limit. The reason it's total and not just active is to avoid the case
where all tasks are dumped into the thread pool since the thread pool is
at the hardware maximum.

During compilation, one manager job is spawned to handle task
allocation and the remaining threads do the compilation work.
revert: "feat: allow adjustment of compiler threads (#99)"
* feat: allow adjustment of compiler threads

Compiler threads may be changed in the `Advanced->Compiler Threads`
menu. Defaults to the available cores - 1, but may be adjusted from 1 to
maximum cores. Compiler threads also have been changed to `background`
priority to prevent lock ups on start.

* fix: fix ctd when terminating compiler threads

Switch to BS:thread_pool to abstract thread management and avoid
overhead of killing and starting threads. Instead, only add jobs to
pool when the number of active and queued threads is less than the
limit. The reason it's total and not just active is to avoid the case
where all tasks are dumped into the thread pool since the thread pool is
at the hardware maximum.

During compilation, one manager job is spawned to handle task
allocation and the remaining threads do the compilation work.

* feat: enable skipping startup shader compilation

Users can now skip shader compilation before it is finished. Shader
compilation will continue using backgroundCompilationThread setting.
Users are also warned that this can result in visual errors or
stuttering while shaders are compiling.
@doodlum doodlum merged commit 4322b19 into static-branching Sep 24, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants